Revert to GitLab branch source 677.x for JCasC compatibility #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enkinsci#2548)" The 679.v1dfd3604d46e release of the GitLab branch source plugin adds the symbol `gitLab` to its implementation of a repository browser in PR-360. The repository browser implementation is used by the git plugin to allow the user to choose the preferred way of displaying links to changes. Unfortunately, the git plugin already defines the symbol `gitLab` for a repository browser implementation. The addition of the new symbol to the GitLab branch source plugin breaks the configuration as code definitions of git plugin users if they have used the gitLab symbol in their definition of global Pipeline libraries. jenkinsci/gitlab-branch-source-plugin#360 (comment) has more details including screenshots. https://github.com/jenkinsci/bom/runs/17272883656 detected the failure while testing the plugin bill of materials with git plugin 5.2.0 and GitLab branch source plugin 679.v1dfd3604d46e. https://issues.jenkins.io/browse/JENKINS-72104 records the GitLab branch source plugin bug that this is reverting. This reverts commit d5e912b.
MarkEWaite
changed the title
MarkEWaite
changed the title
MarkEWaite
changed the title
MarkEWaite
deleted the
revert-gitlab-branch-source-for-JCasC-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert to GitLab branch source 677.v0b_63b_038322b_ for JCasC compatibility
The 679.v1dfd3604d46e release of the GitLab branch source plugin adds the symbol
gitLabto its implementation of a repository browser in PR-360. The repository browser implementation is used by the git plugin to allow the user to choose the preferred way of displaying links to changes.Unfortunately, the git plugin already defines the symbol
gitLabfor a repository browser implementation. The addition of the new symbol to the GitLab branch source plugin breaks the configuration as code definitions of git plugin users if they have used the gitLab symbol in their definition of global Pipeline libraries.jenkinsci/gitlab-branch-source-plugin#360 (comment) has more details including screenshots.
https://github.com/jenkinsci/bom/runs/17272883656 detected the failure while testing the plugin bill of materials with git plugin 5.2.0 and GitLab branch source plugin 679.v1dfd3604d46e.
JENKINS-72104 records the GitLab branch source plugin bug that this is reverting.
This reverts commit d5e912b.
Testing done
Confirmed that git plugin configuration as code tests fail with GitLab branch source 679.v1dfd3604d46e. They pass with GitLab branch source plugin 677.v0b_63b_038322b_.
Submitted pull request to resolve the issue in GitLab branch source plugin:
Submitter checklist