Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flyway api plugin #2912

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

jonesbusy
Copy link
Contributor

This time testcontainertests are ignored when docker environment is missing

For now we will just benefit of InjectedTest and optional version on consumer.

I will see to add other tests that doesn't require testcontainer (maybe just check that the flyway drivers are correctly loaded..). (Will plan to do it for the Flyway 10 upgrade jenkinsci/flyway-api-plugin#9 were Flyway removed some databases implementation from the core dependency)

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@jonesbusy jonesbusy requested a review from a team as a code owner February 9, 2024 13:00
@MarkEWaite
Copy link
Contributor

Thanks @jonesbusy . Since we are nearing the end of the week and will soon release a new version of the plugin bill of materials, I added the weekly-test label to this pull request so that we can check that the tests run successfully with all the recent changes.

@MarkEWaite MarkEWaite enabled auto-merge (squash) February 9, 2024 13:21
@jonesbusy
Copy link
Contributor Author

I'm not sure why the auto-merge failed. Branch is rebased on master

@MarkEWaite
Copy link
Contributor

I'm not sure why the auto-merge failed. Branch is rebased on master

We lock the master branch while a release build is being prepared. In this case, the release build discovered a test failure that is being investigated. @alecharp will unlock the master branch once the investigation has concluded and either the fix is identified or it is confirmed that the failure was transient.

@alecharp
Copy link
Member

Yes everything is OK on this PR @jonesbusy but we have a test failure preventing the release to be done: https://ci.jenkins.io/job/Tools/job/bom/job/master/2494/testReport/io.jenkins.blueocean.service.embedded/PipelineApiTest/pct_blueocean_plugin_2_426_x___testPipelineQueue/. The problem being that I can reproduce the issue on all new commits of this week, including the previous release commit. I'm still investigating.

auto-merge was automatically disabled February 10, 2024 16:58

Base branch was modified

@MarkEWaite MarkEWaite added the enhancement New feature or request label Feb 10, 2024
@MarkEWaite MarkEWaite merged commit 4398b43 into jenkinsci:master Feb 10, 2024
174 checks passed
@jonesbusy jonesbusy deleted the feature/flyway-api-upgrade branch February 10, 2024 19:16
@MarkEWaite MarkEWaite changed the title Add flyway api plugin (docker tests now ignored) Add flyway api plugin Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request weekly-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants