Test on Java 17

[basil]

Do not review. Merely filing this PR for a CI build.

[basil]

Not a bad test run, if I may say so myself! The vast majority of the failures here look like failures in the test code rather than failures in the code under test. These results look good enough to me for us to declare preview Java 17 availability.

[basil]

This failure is a real puzzler so far. In principle core's ListViewTest is doing the same thing, and I can even step through it in Java 17 with the same --add-opens options and see the serialization is successful, but for some reason it is failing in the plugin's test suite (even with the same core version and the latest BOM).

[basil]

This failure is a real puzzler so far. In principle core's ListViewTest is doing the same thing, and I can even step through it in Java 17 with the same --add-opens options and see the serialization is successful, but for some reason it is failing in the plugin's test suite (even with the same core version and the latest BOM).

And of course, after debugging this for an hour and a half, as soon as I write the above, I figure it out. support-core is overriding argLine and drowning out my --add-opens additions, so of course it fails. Simple fix.

[basil]

Most of the failures in ShellStepTest seem to be false positives. I can run 10 out of 13 tests successfully locally, both in PCT (with Java 17 and the changes in this PR) and in the plugin (with Java 17, Jenkins 2.339, and custom --add-opens flags):

PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#abort bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#deadStep bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#encoding bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#label bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#labelShortened bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#launcherDecorator bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#nodePaths bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#returnStatus bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#returnStdout bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#stepDescription bash local-test.sh

These three tests hang consistently, both in PCT (with Java 17 and the changes in this PR) and in the plugin (with Java 17, Jenkins 2.339, and custom --add-opens flags):

PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#missingNewline bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#remoteConsoleNotes bash local-test.sh
PLUGINS=workflow-durable-task-step TEST=org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest#remoteLogger bash local-test.sh

Or maybe they are just really slow? I ran out of patience after a couple of minutes. Perhaps this might ring a bell for @car-roll?

[car-roll]

Or maybe they are just really slow? I ran out of patience after a couple of minutes. Perhaps this might ring a bell for @car-roll?

Those unit tests shouldn't run that long. It does feel like the script isn't launching. Probably warrants more investigation 🧐

[basil]

Those unit tests shouldn't run that long. It does feel like the script isn't launching. Probably warrants more investigation monocle_face

I filed JENKINS-68080 with some steps to reproduce from within workflow-durable-task-step-plugin.

[basil]

As of this week, the core tests and plugin BOM tests are fully passing on Java 17, so this seems like as good a time as any to announce preview support.

[basil]

10 remaining.