Update log4j to 2.15.0 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It requires some seemingly weird changes. 1. Log4j 2.15.0 requires JDK 8 and the older parent-pom was expecting to build with JDK 1.7 and the maven enforcer rejected the jar. So the parent-pom has been updated. 2. The new parent-pom has stronger opinions in Spotbugs - the code has been updated to respect those opinions. 3. The new parent-pom does not like TestNG. However this plugin needs TestNG, so I've disabled the enforcer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires some seemingly weird changes.