Fix checkstyle

jenkinsci · Jun 20, 2019 · c95114f · c95114f
1 parent 3881e99
commit c95114f
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 12 deletions.
diff --git a/src/main/java/com/sonyericsson/jenkins/plugins/bfa/db/MongoDBKnowledgeBase.java b/src/main/java/com/sonyericsson/jenkins/plugins/bfa/db/MongoDBKnowledgeBase.java
@@ -101,6 +101,8 @@ public class MongoDBKnowledgeBase extends KnowledgeBase {
      */
     static final BasicDBObject NOT_REMOVED_QUERY = new BasicDBObject("_removed", new BasicDBObject("$exists", false));
     private static final Logger logger = Logger.getLogger(MongoDBKnowledgeBase.class.getName());
+    private static final int CONNECT_TIMEOUT = 5000;
+    private static final int SERVER_SELECTION_TIMEOUT = 5000;
 
     private transient MongoClient mongo;
     private transient DB db;
@@ -1024,8 +1026,8 @@ private MongoClient getMongoConnection() {
         if (mongo == null) {
             MongoClientOptions mongoClientOptions = MongoClientOptions
                     .builder()
-                    .connectTimeout(5000)
-                    .serverSelectionTimeout(5000)
+                    .connectTimeout(CONNECT_TIMEOUT)
+                    .serverSelectionTimeout(SERVER_SELECTION_TIMEOUT)
                     .build();
             if (password != null && Util.fixEmpty(password.getPlainText()) != null) {
                 char[] pwd = password.getPlainText().toCharArray();

diff --git a/src/test/java/com/sonyericsson/jenkins/plugins/bfa/jcasc/ConfigurationAsCodeLocalTest.java b/src/test/java/com/sonyericsson/jenkins/plugins/bfa/jcasc/ConfigurationAsCodeLocalTest.java
@@ -23,8 +23,7 @@
  */
 public class ConfigurationAsCodeLocalTest {
 
-    static final String NO_CAUSES_MESSAGE = "No problems were identified. Please contribute failure causes to help others "
-            + "occurred, please add a suitable Cause for it.";
+    static final String NO_CAUSES_MESSAGE = "No problems were identified. Please contribute  causes to help others";
     static final int EXPECTED_SCAN_THREADS = 6;
     static final int EXPECTED_MAXIMUM_SOD_WORKER_THREADS = 4;
     static final int EXPECTED_MINIMUM_SOD_WORKER_THREADS = 2;

diff --git a/src/test/resources/com/sonyericsson/jenkins/plugins/bfa/jcasc/jcasc-local-expected.yml b/src/test/resources/com/sonyericsson/jenkins/plugins/bfa/jcasc/jcasc-local-expected.yml
@@ -4,8 +4,7 @@ globalEnabled: true
 graphsEnabled: false
 knowledgeBase: "localFile"
 maxLogSize: 10
-noCausesMessage: "No problems were identified. If you know why this problem occurred,\
-  \ please add a suitable Cause for it."
+noCausesMessage: "No problems were identified. Please contribute  causes to help others"
 nrOfScanThreads: 6
 sodVariables:
   maximumSodWorkerThreads: 4

diff --git a/src/test/resources/com/sonyericsson/jenkins/plugins/bfa/jcasc/jcasc-local.yml b/src/test/resources/com/sonyericsson/jenkins/plugins/bfa/jcasc/jcasc-local.yml
@@ -6,8 +6,7 @@ unclassified:
     graphsEnabled: false
     knowledgeBase: "localFile"
     maxLogSize: 10
-    noCausesMessage: "No problems were identified. If you know why this problem occurred,\
-      \ please add a suitable Cause for it."
+    noCausesMessage: "No problems were identified. Please contribute  causes to help others"
     nrOfScanThreads: 6
     sodVariables:
       maximumSodWorkerThreads: 4

diff --git a/src/test/resources/com/sonyericsson/jenkins/plugins/bfa/jcasc/jcasc-mongo-expected.yml b/src/test/resources/com/sonyericsson/jenkins/plugins/bfa/jcasc/jcasc-mongo-expected.yml
@@ -12,8 +12,7 @@ knowledgeBase:
     successfulLogging: false
     userName: "bfa"
 maxLogSize: 10
-noCausesMessage: "No problems were identified. If you know why this problem occurred,\
-  \ please add a suitable Cause for it."
+noCausesMessage: "No problems were identified. Please contribute  causes to help others"
 nrOfScanThreads: 6
 sodVariables:
   maximumSodWorkerThreads: 4

diff --git a/src/test/resources/com/sonyericsson/jenkins/plugins/bfa/jcasc/jcasc-mongo.yml b/src/test/resources/com/sonyericsson/jenkins/plugins/bfa/jcasc/jcasc-mongo.yml
@@ -14,8 +14,7 @@ unclassified:
         port: 27017
         successfulLogging: false
     maxLogSize: 10
-    noCausesMessage: "No problems were identified. If you know why this problem occurred,\
-      \ please add a suitable Cause for it."
+    noCausesMessage: "No problems were identified. Please contribute  causes to help others"
     nrOfScanThreads: 6
     sodVariables:
       maximumSodWorkerThreads: 4