JENKINS-54439 Jcasc compatibility

[timja]

Migrates from a "Plugin" to a Descriptor
Removes custom databinding in configure

Updates jelly to use data binding
Update parent pom
Remove findbugs config, it's now in parent pom, (using spotbugs instead)
Upgrades checkstyle to allow using lamdas

[timja]

@rsandell mind taking a look please?

[luispollo]

@timja Thanks for contributing this! Been looking forward to this feature. @rsandell Any chance you'd get this merged any time soon?

[timja]

Weirdly changing from a PluginImpl to a GlobalConfiguration / using the initialiser annotations seems to have some impact on classloading. Currently this branch re-introduces the deserialisation issue (albeit with a different error).

Deep in the jackson code:

getTypeFactory().findClass(subClass)

throws:

java.lang.ClassNotFoundException: com.sonyericsson.jenkins.plugins.bfa.model.indication.BuildLogIndication

On master classloader is:
AntClassLoader$ClassicPluginStrategy

AntClassLoader[/Users/timja/projects/jenkinsci/build-failure-analyzer-plugin/src/main/resources:/Users/timja/projects/jenkinsci/build-failure-analyzer-plugin/target/classes:/Users/timja/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.9.3/jackson-annotations-2.9.3.jar:/Users/timja/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.9.7/jackson-databind-2.9.7.jar:/Users/timja/.m2/repository/com/google/code/findbugs/jsr305/1.3.9/jsr305-1.3.9.jar:/Users/timja/.m2/repository/com/google/guava/guava/11.0.1/guava-11.0.1.jar:/Users/timja/.m2/repository/commons-io/commons-io/2.6/commons-io-2.6.jar:/Users/timja/.m2/repository/commons-net/commons-net/3.6/commons-net-3.6.jar:/Users/timja/.m2/repository/de/undercouch/bson4jackson/2.9.2/bson4jackson-2.9.2.jar:/Users/timja/.m2/repository/javax/persistence/persistence-api/1.0.2/persistence-api-1.0.2.jar:/Users/timja/.m2/repository/org/apache/commons/commons-lang3/3.7/commons-lang3-3.7.jar:/Users/timja/.m2/repository/org/mongodb/bson/3.8.0/bson-3.8.0.jar:/Users/timja/.m2/repository/org/mongodb/mongo-java-driver/3.8.2/mongo-java-driver-3.8.2.jar:/Users/timja/.m2/repository/org/mongodb/mongodb-driver-core/3.8.0/mongodb-driver-core-3.8.0.jar:/Users/timja/.m2/repository/org/mongodb/mongodb-driver/3.8.0/mongodb-driver-3.8.0.jar:/Users/timja/.m2/repository/org/mongojack/mongojack/2.9.4/mongojack-2.9.4.jar]

on this PR:
WebAppClassLoader

WebAppClassLoader=Jenkins v2.60.3@1ad4da42

[timja]

Looks like a classloader needs passing, https://jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/

[timja]

All review comments should be fixed / answered, could you please re-review, thanks.

[rsandell]

I'll release all this as a beta version because I'm going on vacation today and will be gone a month. If people are happy then I can release it as a full version. But I don't think I would dare to release it as a full version now when I will not be available to review and release any bugfixes that might arise.