Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress of jobs are not working in IE11/Edge #272

Closed
khipis opened this issue Dec 8, 2016 · 5 comments
Closed

Progress of jobs are not working in IE11/Edge #272

khipis opened this issue Dec 8, 2016 · 5 comments

Comments

@khipis
Copy link
Contributor

khipis commented Dec 8, 2016

Hi!

Progress of builds is not working on IE11/Edge webbrowser (Unfortunately we are obliged to use them on our TV for monitoring master).

We were able to fix that with this workaround:

in controllers.js

directive('animateOnChange', ['$animate', '$timeout', function($animate, $timeout) {
    return function(scope, elem, attr) {
        scope.$watch(attr.animateOnChange, function(newValue, oldValue) {
            if (newValue !== oldValue) {
                var cssClass = 'updated';

                elem[0].style.width = newValue + '%';  //------> THIS LINE IS ADDED

                $animate.addClass(elem, cssClass).then(function() {
                    $timeout(function() {
                        $animate.removeClass(elem, cssClass);
                    }, 5);
                });
            }
        });
    }
}]).

And progress starts to working on IE11/Edge.

However I'm not sure if that solution is ok to make PR from it :)

Regards

@jan-molak
Copy link
Member

Hey @khipis, yeah, that could work, but I think the problem you're seeing has something to do with how IE interprets angular's directives - angular/angular.js#2186

I've just tweaked the implementation slightly, would you mind letting me know if the latest build works better for you?

Thanks,
Jan

@khipis
Copy link
Contributor Author

khipis commented Dec 10, 2016

Yeah, thank you, I will back with feedback as soon as possible (probably end of next week) cheers

@jan-molak
Copy link
Member

Brilliant, if it's all good for you I'll push an update.

@khipis
Copy link
Contributor Author

khipis commented Dec 21, 2016

Hi, sorry for late response.
But now it's confirmed - your solution for this problem works pretty well. Progress is showing on IE11/Edge now.

Thank you very much 👍

@jan-molak
Copy link
Member

Great stuff, thanks for the confirmation. I'll push the latest build to the Update Centre shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants