[JENKINS-68022] Fix icon usage

[alecharp]

Since Jenkins 2.337 and jenkinsci/jenkins#5778, the PNG icons were removed from Jenkins core. Only SVG files remains.

With this PR, I propose a fix to use the image correctly on recent versions of Jenkins. See the before in JENKINS-68022

Sadly, the first commit was mandatory here to be able to start the plugin locally, and so anyone can test the changes.

After:

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[soprano8086]

Hi,
We hit this issue recently. Anyone can fix the test and merge?
Thanks

[taylorbasso]

Also running into this... Unfortunately I was not able to build this locally due to some access-modifier-checker error. It looks like I'm getting the same error as the failing build:

[INFO] --- access-modifier-checker:1.27:enforce (default-enforce) @ build-pipeline-plugin --- [ERROR] au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTrigger$DescriptorImpl:310 hudson/tasks/Messages must not be used [ERROR] au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTrigger$DescriptorImpl:314 hudson/tasks/Messages must not be used [ERROR] au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTrigger$DescriptorImpl:318 hudson/tasks/Messages must not be used [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 14.179 s [INFO] Finished at: 2022-08-02T15:29:54-06:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.kohsuke:access-modifier-checker:1.27:enforce (default-enforce) on project build-pipeline-plugin: Access modifier checks failed. See the details above -> [Help 1]

[alexhass]

As interrim workaround I copied all the images into the required folder, but this is not a good solution.

When can we expect a fix?

[Panajev]

Sorry for pinging about this, bit is there any update on this?

[Vincevrp]

As interrim workaround I copied all the images into the required folder, but this is not a good solution.

When can we expect a fix?

I've temporarily done the same thing. Is there any update on this?

[aikar]

For anyone else wanting to restore it as previous people mentioned they did, if you go download some say 2xx build of jenkins .war file, extract the files with unzip blah.war

then delete any svg's in the images folder
find images -name "*.svg" -delete

then update your current war with
jar uvf /path/to/2.361.2.war images/

the svg part is important to not overwrite any existing svg's or itll break the verification from web-inf folder.
Wasn't important enough to polish anymore than this for now.

[ryanwaite28]

Hi, is there any intention on merging this PR?

[alecharp]

@dalvizu would you be able to review this PR and potentially merge it and release the plugin? It seems that this fix would help users.

[alexhass]

Any chance for a release?

[kumadee]

@gluehbirnenkopf @PK89SC @ravindrareddy-cht Any idea when this fix will be merged and released? It's annoying.

[zia-aws]

Any idea when this going to be released?

[arpit-patel1]

Hi, Is there any plans on this PR being merged ? I would really like to help out here if needed. Please let me know.

[MarkEWaite]

@alexhass , @kumadee, @zia-aws, and @arpit-patel1 the fix is unlikely to be released unless one or more of you adopt the plugin, merge the fix, and release a new version of the plugin.

There are now two other pull requests that build on the work in this pull request. Those pull requests make it easier for someone to adopt the plugin.

• Repair build for latest Jenkins version #125
• Require Java 11 and Jenkins 2.361.4 or newer #126

[dalvizu]

Cherry picked and merged in #126

[dalvizu]

Released in 2.0.0

[MarkEWaite]

Thanks very much @dalvizu !