Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72581] Replace Prototype.js in the 'Run' button #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarkEWaite
Copy link

@MarkEWaite MarkEWaite commented Jan 18, 2024

[JENKINS-72581] Replace Prototype.js in the "Run" button

JENKINS-72581 describes the failure with Jenkins 2.426.2. The "Run" button reports a JavaScript error rather than starting the build. With this change, the build starts as expected. Change was made based on the instructions in the Prototype.js removal blog post.

Does not fix the "Delete" button. That needs to be replaced with the modern version of delete that will use a modal dialog.

Testing done

Interactive testing confirmed that I can duplicate the problem before this change and that after this change, the Run button behaves as expected.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

https://issues.jenkins.io/browse/JENKINS-72581 describes the failure
with Jenkins 2.426.2.

Does not fix the "Delete" button.  That needs to be replaced with the
modern version of delete that will use a modal dialog.
@MarkEWaite
Copy link
Author

@dalvizu this is another one that I've tested well enough to justify a release. The "Delete" button doesn't work with Jenkins 2.426.2, but that will need to be a different fix.

@dalvizu
Copy link
Member

dalvizu commented Jan 18, 2024

Do you have permissions to merge and create a release? I contribute almost no value to this project now, so am fine with you moving unilaterally on any fixes that you're willing to support and maintain. I have minimal time to contribute here and no technical resources beyond an environment I can cut a release from and permissions to do so. I'm happy to continue doing that, if it's valuable, but don't want you to be waiting on things when you can be moving faster.

When I started maintaining this plugin, I was a full time Java engineer building CI/CD and using this plugin for our production workflows. I'm now in senior management and don't use this technology in any capacity.

@MarkEWaite
Copy link
Author

Do you have permissions to merge and create a release?

I don't have those permissions and am not ready to add this plugin to the group of plugins that I maintain. I'm not a user of the plugin. I think that users of the plugin are the preferred maintainers.

I have minimal time to contribute here and no technical resources beyond an environment I can cut a release from and permissions to do so. I'm happy to continue doing that, if it's valuable, but don't want you to be waiting on things when you can be moving faster.

Creating a new release is valuable and a great help. I hope the impact on your time is low and I'm very grateful if you are willing to continue doing that.

@basil basil added the bug label Mar 29, 2024
@MarkEWaite
Copy link
Author

@dalvizu does your time allow you to merge this and create a release? I understand if it does not, that's not a problem, but I thought it was worth a check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants