Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fancybox 1.3.4 for latest jQuery #78

Merged
merged 1 commit into from
Nov 20, 2015
Merged

Conversation

phantom-d
Copy link

I recommend change fancybox to http://dimsemenov.com/plugins/magnific-popup/

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@KostyaSha
Copy link
Member

Please provide screenshots before and after, plus described why plugin should bundle additional js file (what license does it has?)

@mbidewell
Copy link

Something needs to be done about fancyBox, the fancyBox-jQuery compatibility issue not only impacts console output (which can be worked around), but also blocks the execution of pipelines with parameters (which cannot be worked around).

@mbidewell
Copy link

jquery migrate is provided by jQuery and is licensed MIT (http://blog.jquery.com/2013/05/08/jquery-migrate-1-2-1-released/). It is a compatibility shim which reenables removed functionality in jQuery which fancyBox relies on. There is no little to no visual difference. Long term, moving to a library like Magnific Popup that is maintanable would be good (assuming the fancyBox 2.0 licence change renders it unusable), but in the short term, pushing this fix will reenable some vital functionality
jquery_fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants