Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable builds are treated as neutral #11

Closed
timja opened this issue Aug 11, 2020 · 0 comments · Fixed by #12
Closed

Unstable builds are treated as neutral #11

timja opened this issue Aug 11, 2020 · 0 comments · Fixed by #12
Labels
bug Something isn't working

Comments

@timja
Copy link
Member

timja commented Aug 11, 2020

Unstable builds contains test failures and should be marked as failed

See

checks-api-plugin/src/main/java/io/jenkins/plugins/checks/BuildStatusChecksPublisher.java

Line 94 in 3d21dbb

return ChecksConclusion.NEUTRAL;

https://gitter.im/jenkinsci/warnings-plugin?at=5f32ff4d4c89605c7f8d6b27

cc @XiongKezhi
@XiongKezhi XiongKezhi added the bug Something isn't working label Aug 12, 2020
@XiongKezhi XiongKezhi mentioned this issue Aug 12, 2020
Merged
XiongKezhi added a commit that referenced this issue Oct 25, 2020
@XiongKezhi
Merge pull request #11 from jenkinsci/dependabot/maven/net.javacrumbs…
8a17faf 
….json-unit-json-unit-core-2.18.1

Bump json-unit-core from 2.17.0 to 2.18.1
@XiongKezhi XiongKezhi mentioned this issue Nov 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Map unstable build to check failure jenkinsci/checks-api-plugin
2 participants
@timja @XiongKezhi