Fixed doesStreamExists throwing Exception even when stream does not exists #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases except when stream exists
|
plugins » clearcase-plugin #74 SUCCESS |
|
I guess you refer to PR #29. |
| String cleartoolResult = baos.toString(); | ||
| return !(cleartoolResult.contains("stream not found")); | ||
| if (!(cleartoolResult.contains("stream not found"))) { |
There was a problem hiding this comment.
I think the intent would be clearer if the condition was inverted.
|
plugins » clearcase-plugin #75 SUCCESS |
Vlatombe
added a commit
that referenced
this pull request
Jul 3, 2014
Fixed doesStreamExists throwing Exception even when stream does not exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously proposed fix resolved the issue where doesStreamExists will return true in case the command failed but introduced a regression, causing an Exception to be thrown even when the stream does not exists.
Now the exception thrown by the command will be caught and the command output checked to verify either if the stream does not exists or if another error occured, rethrowing the exception in the second case.