Skip to content

Commit

Permalink
Merge pull request #65 from jglick/JENKINS-32178-Javadoc
Browse files Browse the repository at this point in the history
[JENKINS-32178] Noting why you should not override getUrlChildPrefix
  • Loading branch information
jglick committed Jun 1, 2016
2 parents 9987689 + 40f005e commit 214079b
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -324,6 +324,11 @@ public File getRootDirFor(I child) {
return getRootDirFor(child.getName()); // TODO see comment regarding loadChildren and encoding return getRootDirFor(child.getName()); // TODO see comment regarding loadChildren and encoding
} }


/**
* It is unwise to override this, lest links to children from nondefault {@link View}s break.
* TODO remove this warning if and when JENKINS-35243 is fixed in the baseline.
* {@inheritDoc}
*/
@Override @Override
public String getUrlChildPrefix() { public String getUrlChildPrefix() {
return "job"; return "job";
Expand Down

0 comments on commit 214079b

Please sign in to comment.