jep-227 downstream usage #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Oct 27, 2023
Comment on lines
-110
to
-112
| public <C extends Credentials> List<C> getCredentials(@NonNull Class<C> type, @Nullable ItemGroup itemGroup, | ||
| @Nullable Authentication authentication) { | ||
| return getCredentials(type, itemGroup, authentication, Collections.emptyList()); |
| @Nullable Authentication authentication, | ||
| @NonNull List<DomainRequirement> domainRequirements) { | ||
| if (item instanceof AbstractFolder) { | ||
| // credentials defined in the folder should be available in the context of the folder | ||
| return getCredentials(type, (ItemGroup) item, authentication, domainRequirements); | ||
| return getCredentialsInItemGroup(type, (ItemGroup) item, authentication, domainRequirements); |
Comment on lines
-86
to
+85
| CredentialsProvider.lookupCredentials(StandardUsernamePasswordCredentials.class, (ItemGroup) f, | ||
| ACL.SYSTEM, Collections.emptyList()); | ||
| CredentialsProvider.lookupCredentialsInItemGroup(StandardUsernamePasswordCredentials.class, f, |
There was a problem hiding this comment.
no cast needed for method resolution 👍
jglick
reviewed
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-XXXXX.
Proposed changelog entries
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)