[JENKINS-71651] Fix administrative monitor buttons

[rkivisto]

JENKINS-71651

Reproduction environment

A fresh install of Jenkins 2.401.2 LTS
Choosing to install no plugins during the wizard
Installing Health Advisor by CloudBees (https://plugins.jenkins.io/cloudbees-jenkins-advisor/) Version 336.v4d00382fe22c

openjdk version "11.0.18" 2023-01-17
OpenJDK Runtime Environment Temurin-11.0.18+10 (build 11.0.18+10)
OpenJDK 64-Bit Server VM Temurin-11.0.18+10 (build 11.0.18+10, mixed mode)

Issue

When clicking the "Configure Now" or "Uninstall Plugin" buttons in the administrative monitor for Jenkins Health Advisor by CloudBees plugin, the buttons do not redirect you:

Expected behaviour

Usually these buttons redirect you to:
JENKINS_URL/manage/cloudbees-jenkins-advisor/
JENKINS_URL/pluginManager/installed

Testing done

After my changes were implemented, I again ran: mvn hpi:run -Djenkins.version=2.404 and the administrative monitor is working again:

I also ran mvn clean verify and all the tests pass still, and took the target/cloudbees-jenkins-advisor.hpi and installed it on my Jenkins 2.401.2 LTS instance described in the Reproduction environment, and after restarting, the administrative monitor was also working correctly now:

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[Dohbedoh]

Found out that the real problem originates from the use of @QueryParameter#fixEmpty. Maybe this is an impact of a Stapler upgrade in Core ? not sure..

[PierreBtz]

I don't understand the link between the removal Prototype js and your fix tbh.

Edit: ok reading Allan's update now, it makes more sense.

[PierreBtz]

Caused by jenkinsci/jenkins#7203