Do not show an icon in checks report when the coverage did not change.

Fixes #662
jenkinsci · May 8, 2023 · 2858a7e · 2858a7e
1 parent e486bea
commit 2858a7e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/CoverageChecksPublisher.java b/plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/CoverageChecksPublisher.java
@@ -52,6 +52,7 @@ class CoverageChecksPublisher {
     private static final int TITLE_HEADER_LEVEL = 4;
     private static final char NEW_LINE = '\n';
     private static final String COLUMN = "|";
+    private static final String GAP = " ";
 
     private final CoverageBuildAction action;
     private final Node rootNode;
@@ -434,29 +435,29 @@ private String formatText(final TextFormat format, final String text) {
     }
 
     private String getTrendIcon(final String trend) {
+        if (!StringUtils.containsAny(trend, "123456789") || trend.startsWith("n/a")) {
+            return StringUtils.EMPTY;
+        }
         if (trend.startsWith("+")) {
-            return " " + Icon.ARROW_UP.markdown;
+            return GAP + Icon.ARROW_UP.markdown;
         }
         else if (trend.startsWith("-")) {
-            return " " + Icon.ARROW_DOWN.markdown;
-        }
-        else if (trend.startsWith("n/a")) {
-            return StringUtils.EMPTY;
+            return GAP + Icon.ARROW_DOWN.markdown;
         }
-        return " " + Icon.ARROW_RIGHT.markdown;
+        return GAP + Icon.ARROW_RIGHT.markdown;
     }
 
     private String getBulletListItem(final int level, final String text) {
         int whitespaces = (level - 1) * TITLE_HEADER_LEVEL;
-        return String.join("", Collections.nCopies(whitespaces, " ")) + "* " + text + "\n";
+        return String.join("", Collections.nCopies(whitespaces, GAP)) + "* " + text + "\n";
     }
 
     private String getUrlText(final String text, final String url) {
         return String.format("[%s](%s)", text, url);
     }
 
     private String getSectionHeader(final int level, final String text) {
-        return String.join("", Collections.nCopies(level, "#")) + " " + text + "\n\n";
+        return String.join("", Collections.nCopies(level, "#")) + GAP + text + "\n\n";
     }
 
     private ChecksConclusion getCheckConclusion(final QualityGateStatus status) {

diff --git a/.../src/test/java/io/jenkins/plugins/coverage/metrics/steps/CoverageChecksPublisherTest.java b/.../src/test/java/io/jenkins/plugins/coverage/metrics/steps/CoverageChecksPublisherTest.java
@@ -216,7 +216,7 @@ private CoverageBuildAction createCoverageBuildAction(final Node result) {
 
         return new CoverageBuildAction(run, COVERAGE_ID, REPORT_NAME, StringUtils.EMPTY, result,
                 new QualityGateResult(), null, "refId",
-                new TreeMap<>(Map.of(Metric.LINE, Fraction.ONE_HALF, Metric.MODULE, Fraction.ONE_FIFTH)),
+                new TreeMap<>(Map.of(Metric.LINE, Fraction.ONE_HALF, Metric.MODULE, Fraction.ZERO)),
                 List.of(testCoverage), new TreeMap<>(Map.of(Metric.LINE, Fraction.ONE_HALF)), List.of(testCoverage),
                 new TreeMap<>(Map.of(Metric.LINE, Fraction.ONE_HALF)), List.of(testCoverage), false);
     }

diff --git a/.../jenkins/plugins/coverage/metrics/steps/coverage-publisher-details.checks-expected-result b/.../jenkins/plugins/coverage/metrics/steps/coverage-publisher-details.checks-expected-result
@@ -3,7 +3,7 @@
 ||Module Coverage|Package Coverage|File Coverage|Class Coverage|Method Coverage|Line Coverage|Branch Coverage|Instruction Coverage
 |:---:|:---:|:---:|:---:|:---:|:---:|:---:|:---:|:---:
 :feet: **Overall project**|100.00% (1/1)|100.00% (4/4)|70.00% (7/10)|83.33% (15/18)|95.10% (97/102)|91.02% (294/323)|93.97% (109/116)|93.33% (1260/1350)
-:chart_with_upwards_trend: **Overall project (difference to reference job)**|+20.00% :arrow_up:|n/a|n/a|n/a|n/a|+50.00% :arrow_up:|n/a|n/a
+:chart_with_upwards_trend: **Overall project (difference to reference job)**|+0.00%|n/a|n/a|n/a|n/a|+50.00% :arrow_up:|n/a|n/a
 :feet: **Modified files**|n/a|n/a|n/a|n/a|n/a|50.00% (1/2)|n/a|n/a
 :chart_with_upwards_trend: **Modified files (difference to overall project)**|n/a|n/a|n/a|n/a|n/a|+50.00% :arrow_up:|n/a|n/a
 :feet: **Modified code lines**|n/a|n/a|n/a|n/a|n/a|50.00% (1/2)|n/a|n/a