Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate GitHub Checks names when calling publishCoverage multiple times #204

Closed
medianick opened this issue Aug 20, 2021 · 1 comment · Fixed by #518
Closed

Disambiguate GitHub Checks names when calling publishCoverage multiple times #204

medianick opened this issue Aug 20, 2021 · 1 comment · Fixed by #518
Labels
enhancement Enhancement of existing functionality

Comments

@medianick
Copy link
Contributor

Dependencies

Possibly Checks API 1.2.0, depending on the chosen solution.

Feature Request

Currently the Checks name published to GitHub is hard-coded to "Code Coverage":

This would be fine if publishCoverage were only ever called once in a given pipeline, but with the support for calling it multiple times (e.g., using a tag to merge the results), each invocation overwrites any "Code Coverage" check(s) published previously.

The approach used by the JUnit plugin in jenkinsci/junit-plugin#211 would be a good way to solve this by default. Additionally or instead, adding support for the withChecks capability introduced in Checks API 1.2.0 would offer another possible solution.

@uhafner
Copy link
Member

uhafner commented Aug 22, 2021

Interested in providing a PR? I think nobody has the time to look at new features right now.

@uhafner uhafner added enhancement Enhancement of existing functionality hacktoberfest Pull requests that participate in Hacktoberfest labels Oct 1, 2021
@uhafner uhafner removed the hacktoberfest Pull requests that participate in Hacktoberfest label Nov 3, 2021
uhafner added a commit that referenced this issue Nov 16, 2022
…-Parameter

Add a SCM checksName parameter - Issue #204
@uhafner uhafner linked a pull request Nov 16, 2022 that will close this issue
@uhafner uhafner closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants