Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source files partially copied when transient agent is destroyed (i.e. Docker) #82

Closed
capadgett opened this issue May 8, 2019 · 2 comments

Comments

@capadgett
Copy link

Thanks for the awesome plugin (efficient, snappy interface, etc.).

When using a transient docker agent, I see files in the build directory on the Jenkins master that are partially copied or empty, and have the trailing _copied at the end of the file name.

I am not positive, but I think this issue is related to not waiting for the ExecutorService in io/jenkins/plugins/coverage/source/DefaultSourceFileResolver.java:

   81         ExecutorService service = Executors.newFixedThreadPool(5);
   82
   83         paints.forEach((sourceFilePath, paint) -> {
   84             service.submit(() -> {                                              

I should also mention that I am using the publishCoverage pipeline step in a stage{ post{} }, not a pipeline{ post{} }, but I wouldn't think that should matter.

Might be related to fix for #77

@cizezsy
Copy link
Contributor

cizezsy commented May 9, 2019

@capadgett You are right, ExecutorService cannot prevent agent from destroyed so not be able to copy all source files. Thanks for the feedback, I will try to fix it in next release.

cizezsy added a commit that referenced this issue May 13, 2019
Source files will partially copied when using transient agent.

see: #82
@cizezsy
Copy link
Contributor

cizezsy commented May 22, 2019

@capadgett Fixed in version 1.0.11, thanks :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants