Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve source file resolving #131

Merged
merged 6 commits into from
Dec 16, 2019
Merged

Improve source file resolving #131

merged 6 commits into from
Dec 16, 2019

Conversation

cizezsy
Copy link
Contributor

@cizezsy cizezsy commented Nov 22, 2019 •
edited

@cizezsy cizezsy changed the title Fix: cannot read source file with absolute path Improve source file resolving Nov 27, 2019
@cizezsy cizezsy force-pushed the fix/absolute-source-file branch 2 times, most recently from 3b04f8a to 26addf8 Compare November 27, 2019 06:28
@cizezsy cizezsy force-pushed the fix/absolute-source-file branch 2 times, most recently from e815abb to b8e712c Compare November 28, 2019 03:00
@cizezsy cizezsy force-pushed the fix/absolute-source-file branch 2 times, most recently from d366341 to 229e59d Compare December 11, 2019 10:08
@cizezsy cizezsy merged commit 46cdf18 into dev Dec 16, 2019
@cizezsy cizezsy deleted the fix/absolute-source-file branch December 16, 2019 10:02
@tuky
Copy link

tuky commented Jan 23, 2020

For us, this unfortunately stopped relative source file resolution from working. we're running

publishCoverage adapters: [istanbulCoberturaAdapter('coverage/coverage.xml')], ...

where the <project root>/coverage/coverage.xml will contain

<source>../src</source>

Downgrading to 1.1.1 fixes this for us again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Cannot found source..." error with Cobertura Reports with Fully Qualified Filename property
2 participants
@cizezsy @tuky