Fix small HTML tags errors in painted source code files #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML generated with painted source code has a bunch of errors with tags that may make the rendering bad on older browsers or may anyhow leave to the browser the freedom to rearrange the code.
Example from Firefox source code parsing:
In the example you see that the closing of
<a>is considered invalid (it is not a void element) and the<td>of hits is never closed. Also the whole table was inside a<pre>(preformatted) tag which doesn't make sense it being a table.This PR fixes this little HTML quirks and makes the page more HTML5 compliant.