display name contains "<" and/or ">" (<init> for example) normally #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, this api plugin would display "<init>" method as "&lt;init&gt;" when showing coverage report for the method.
Generally, this bug occurs when the method name contains "<" and/or ">". Let's still take "<init>" for example, after the process of
io.jenkins.plugins.coverage.targets.CoverageResult#xmlTransform, this name will be "<init>", then since the corresponding jelly file'sescape-by-defaultproperty is true, the name will be further escaped to "&lt;init&gt;".When displaying the method name, the text is displayed "as is", so escaping is not necessary. So this PR won't lead to XSS issues.
After this change, the display will work fine.