Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate echarts-api plugin #197

Merged
merged 1 commit into from
May 22, 2021
Merged

integrate echarts-api plugin #197

merged 1 commit into from
May 22, 2021

Conversation

simonsymhoven
Copy link
Member

Remove local copy of echarts and integrate echarts-api plugin. See #182.
Charts are still rendered as expected.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@simonsymhoven simonsymhoven mentioned this pull request May 21, 2021
Closed
timja
timja approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you manually tested it?

@timja timja added the chore label May 22, 2021
@simonsymhoven
Copy link
Member Author

Have you manually tested it?

Yes :)

@timja timja merged commit 0c5c4b3 into jenkinsci:master May 22, 2021
@simonsymhoven simonsymhoven deleted the echarts-plugin-integration branch May 22, 2021 07:01
@uhafner
Copy link
Member

uhafner commented May 22, 2021

Fixes https://issues.jenkins.io/browse/JENKINS-62633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonsymhoven @uhafner @timja