Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix splitPackages for some corner cases #224

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Fix splitPackages for some corner cases #224

merged 1 commit into from
Oct 6, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Oct 6, 2021

  • If the package name contains a single dot, then splitting broke with an exception.
  • If the module node does not contain packages, then the next sub nodes have been split.
  • If the package name does not contain dots, then the package was deleted.

Fixes #223.

@uhafner
Fix splitPackages for some corner cases.
6a7730e 
- If the package name contains a single dot, then splitting broke with an exception.
- If the module node does not contain packages, then the next sub nodes have been split.
- If the package name does not contain dots, then the package was deleted.
@uhafner uhafner added the bug Bugs or performance problems label Oct 6, 2021
@uhafner uhafner merged commit b8344a5 into master Oct 6, 2021
@uhafner uhafner deleted the package-split branch October 6, 2021 12:34
@uhafner uhafner added the hacktoberfest Pull requests that participate in Hacktoberfest label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
bug Bugs or performance problems hacktoberfest Pull requests that participate in Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error/Exception with v2.0.0
2 participants
@uhafner @timja