Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail when report is missing in reference build #232

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

zbynek
Copy link

@zbynek zbynek commented Oct 14, 2021

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • [n/a] Link to relevant issues in GitHub or Jira
  • [n/a] Link to relevant pull requests, esp. upstream and downstream changes
  • [TODO] Ensure you have provided tests - that demonstrates feature works or fixes the issue

As an administrator I want to be able to remove the coverage .xml files for old builds without breaking new builds. Clearly this should be done using some log-rotate feature in Jenkins, but it would be nice if the plugin could handle the case when I do it by simply removing the files from the filesystem.

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #232 (8e25b06) into master (81dc044) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage     57.98%   57.98%           
  Complexity      480      480           
=========================================
  Files            56       56           
  Lines          2304     2304           
  Branches        289      289           
=========================================
  Hits           1336     1336           
  Misses          863      863           
  Partials        105      105           
Impacted Files Coverage Δ
...io/jenkins/plugins/coverage/CoverageProcessor.java 63.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81dc044...8e25b06. Read the comment docs.

@zbynek
Copy link
Author

zbynek commented Oct 14, 2021

@uhafner I didn't find any test coverage for the diff handling. Do you expect a test for this PR?

@uhafner
Copy link
Member

uhafner commented Oct 14, 2021

No, for this change no test is required.

BTW: this will only work for the results in the old (non-xml) report serializations. The new XML based serialization is not yet used for the delta computation.

@uhafner uhafner added the bug Bugs or performance problems label Oct 14, 2021
@uhafner uhafner changed the title Handle misssing XML file from previous build Do not fail when report is missing in reference build Oct 14, 2021
@uhafner uhafner merged commit 7608529 into jenkinsci:master Oct 14, 2021
@zbynek zbynek deleted the handle-missing-xml branch October 14, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants