Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case to expose issues #227 and #231 #243

Merged
merged 4 commits into from
Nov 3, 2021
Merged

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Nov 3, 2021

The actual fix is done in the upstream module. This PR just adds a test to expose the issues

See jenkinsci/plugin-util-api-plugin#133

@uhafner uhafner added bug Bugs or performance problems tests Enhancement of tests labels Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #243 (5b2bd30) into master (3265db1) will increase coverage by 0.19%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #243      +/-   ##
============================================
+ Coverage     57.98%   58.17%   +0.19%     
- Complexity      480      483       +3     
============================================
  Files            56       56              
  Lines          2304     2305       +1     
  Branches        289      290       +1     
============================================
+ Hits           1336     1341       +5     
+ Misses          863      858       -5     
- Partials        105      106       +1     
Impacted Files Coverage Δ
...ins/plugins/coverage/model/CoverageTrendChart.java 94.73% <91.66%> (-5.27%) ⬇️
...kins/plugins/coverage/model/CoverageJobAction.java 50.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3265db1...5b2bd30. Read the comment docs.

@uhafner uhafner merged commit 12209a9 into master Nov 3, 2021
@uhafner uhafner deleted the broken-job-link branch November 3, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems tests Enhancement of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants