[JENKINS-51363] Pipeline support #5
Conversation
cizezsy
commented
May 25, 2018
cizezsy
commented
- add @symbol on CoveragePublisher
- remove optional params in @DataBoundConstructor constructor, and using @DataBoundSetter public propery setter to config them.
- fix bug in XMLCoverageReportAdapter, which when plugin is packaged, xsl will not be properly find.
- add @symbol on CoveragePublisher - remove optional params in @DataBoundConstructor constructor, and using @DataBoundSetter public propery setter to config them. - fix bug in XMLCoverageReportAdapter, which when plugin is packaged, xsl will not be propery find.
| this.autoDetectPath = autoDetectPath; | ||
| } | ||
|
|
||
| @Symbol("coverage") |
|
@oleg-nenashev Thresh branch is based on this branch, so I think I should not do too many changes in this branch. I will add more unit test in Thresh branch. |
| @@ -107,6 +107,7 @@ public CoverageResult processCoverageReport() throws IOException, InterruptedExc | |||
|
|
|||
| // If enable automatically detecting, it will try to find report and correspond adapter. | |||
| if (isEnableAutoDetect()) { | |||
| listener.getLogger().println("Auto Detect is enable: Start to detect report"); | |||
There was a problem hiding this comment.
- enabled.
- Looking for reports (maybe)
|
|
||
| } | ||
|
|
||
| public static class CoverageScriptedPipelineScriptBuilder { |
There was a problem hiding this comment.
Maybe it was an overkill. It could be preferable to just have scripts, which can be later used for documentation purposes
|
|
||
| private String generateSnippetForThreshold(Threshold threshold) { | ||
|
|
||
| return "[healthyThresh:" + threshold.getHealthyThresh() |
There was a problem hiding this comment.
"thresh" is probably a bad wording for UI and API. It has different meaning (@jeffpearce please correct me if I am wrong). Does it come from Cobertura plugin? If no, I would recommend using a full "threashold" everywhere in API and Symbols
There was a problem hiding this comment.
Yeah, I will change them in threshold branch.
| @@ -35,6 +36,7 @@ public String getXSD() { | |||
| return null; | |||
| } | |||
|
|
|||
| @Symbol("coberturaAdapter") | |||
There was a problem hiding this comment.
maybe just cobertura() ? "Adapter" is an implementation detail
| @@ -26,6 +27,7 @@ public String getXSD() { | |||
| return null; | |||
| } | |||
|
|
|||
| @Symbol("jacocoAdapter") | |||
…Fix some incorrect spells.
|
I have merged this pull request, and I will do all further changes in thresh branch. |
