Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redraw the trend charts when user changes color theme (dark/light mode) #765

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Sep 18, 2023

When the users (or the system) changes from dark to light mode (or the other way round), then the charts need to be re-rendered to use the correct background and foreground colors.

@uhafner uhafner added the bug Bugs or performance problems label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #765 (b29d550) into master (efff644) will not change coverage.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #765   +/-   ##
=========================================
  Coverage     73.54%   73.54%           
  Complexity     1689     1689           
=========================================
  Files           130      130           
  Lines          6278     6278           
  Branches        676      676           
=========================================
  Hits           4617     4617           
  Misses         1439     1439           
  Partials        222      222           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner merged commit 15ce96e into master Sep 19, 2023
29 checks passed
@uhafner uhafner deleted the refresh-chart-on-dark-mode-event branch September 19, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant