Added BasicAuthentication support for jenkins CLI access #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI and web API for jenkins use Basic Authorization in the HTTP requests. Teamforge uses either a login one time token or a n HTML login form. The collabnet-plugin supports the two teamforge authentication schemes but not Basic Authorization. This pull crudely adds support for Basic Authorization.
Basically try login with token, then basic authentication login, then fallback to the html login form.
This should resolve https://issues.jenkins-ci.org/browse/JENKINS-10727
Test build using maven 3.2.1, oracle java 1.7.0_76 JDK and jenkins-war-1.549. Then the build plugin uploaded to jenkins 1.598 and verified.
Notes: