Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warning: Ignoring deprecated java.level property #11

Closed
wants to merge 1 commit into from

Conversation

basil
Copy link
Member

@basil basil commented Jun 2, 2022

Steps to reproduce

Run mvn clean verify -DskipTests as of HEAD (at the time of current writing, commit afa4de2).

Expected Results

The build completes with no warnings.

Actual Results

The build completes with the following warning:

[…]
[INFO] --- maven-hpi-plugin:3.27:validate (default-validate) @ commons-lang3-api ---
[WARNING] Ignoring deprecated java.level property. This property should be removed from your plugin's POM. In the future this warning will be changed to an error and will break the build.
[…]

Evaluation

Commit bb7726b was integrated without reading release notes: jenkinsci/plugin-pom#522. As the warning states, this property now has no effect and should be removed from the plugin's POM.

Solution

Remove the unused property from the plugin's POM.

Testing done

Reproduced the problem as described above. Before this PR, the problem could be reproduced as described above. After this PR, the problem can no longer be reproduced.

CC @nhojpatrick

@basil basil requested a review from a team as a code owner June 2, 2022 16:09
@basil
Copy link
Member Author

basil commented Jun 10, 2022

@nhojpatrick ?

@basil
Copy link
Member Author

basil commented Jul 9, 2022

@nhojpatrick Gentle ping

@nhojpatrick
Copy link
Contributor

Cheers @basil spotted after I merged #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants