Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize to Jenkins 2.401.3 #57

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Modernize to Jenkins 2.401.3 #57

merged 2 commits into from
Dec 5, 2023

Conversation

sghill-rewrite
Copy link
Contributor

@sghill-rewrite sghill-rewrite commented Dec 2, 2023 •
edited
Loading

Hi!

This PR aims to modernize tooling and move this plugin to the recommended Jenkins baseline version.

2.401.2 was the first version to include Guice 6.x, which supports jakarta.inject.

Testing done

Ran mvn clean verify.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options
Loading

Refs: sghill-rewrite/campaigns#1

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin

@sghill-rewrite @TeamModerne
Modernize Jenkins baseline to 2.401.3
d76a280 
Includes refactoring to jakarta.inject

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin

Co-authored-by: Moderne <team@moderne.io>
@sghill-rewrite sghill-rewrite requested a review from a team as a code owner December 2, 2023 02:30
@sghill-rewrite @TeamModerne
Modernize Jenkins baseline to 2.401.3
c0cda68 
Includes refactoring to jakarta.inject

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin

Co-authored-by: Moderne <team@moderne.io>
@sghill sghill added enhancement New feature or request dependencies Pull requests that update a dependency file labels Dec 5, 2023
@sghill sghill merged commit 22ad30e into jenkinsci:main Dec 5, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sghill sghill sghill approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sghill-rewrite @sghill