Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings for spotbugs 4.8.3 #310

Merged

Conversation

MarkEWaite
Copy link
Contributor

Suppress warnings for spotbugs 4.8.3

Plugin pom 4.77 needs this change to resolve new spotbugs warnings that will be reported by spotbugs 4.8.3 and later.

Can skip the changelog, since this is not visible to users.

Testing done

Confirmed that the spotbugs warnings are visible when using the 4.77-SNAPSHOT plugin pom before this change. With this change, the spotbugs warnings are no longer visible.

Confirmed that spotbugs is silent with plugin pom 4.77 after this change.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
Loading

https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77 needs
this change to resolve new spotbugs warnings that will be reported by
spotbugs 4.8.3 and later.

Confirmed that the spotbugs warnings are visible when using the
4.77-SNAPSHOT plugin pom before this change. With this change, the
spotbugs warnings are no longer visible.

Confirmed that spotbugs is silent with plugin pom 4.77 after this
change.

Can skip the changelog, since this is not visible to users.
@MarkEWaite MarkEWaite requested a review from a team as a code owner January 16, 2024 01:13
@MarkEWaite
Copy link
Contributor Author

Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MarkEWaite.

@alecharp alecharp added this pull request to the merge queue Jan 16, 2024
Merged via the queue into jenkinsci:master with commit 6fb4fd5 Jan 16, 2024
14 checks passed
@MarkEWaite MarkEWaite deleted the suppress-more-spotbugs-warnings branch March 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants