Improved target path parsing for Config File. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/main/java/org/jenkinsci/plugins/configfiles/maven/job/MvnGlobalSettingsProvider.java src/main/java/org/jenkinsci/plugins/configfiles/maven/job/MvnSettingsProvider.java src/main/java/org/jenkinsci/plugins/configfiles/maven/security/CredentialsHelper.java src/test/java/org/jenkinsci/plugins/configfiles/maven/security/CredentialsHelperTest.java
Checking for "." anywhere in full filepath is a poor way of determining whether a path is to a file or a directory. Naming conventions allow for periods in directory names and do not necessitate them in file names. Plugin should assume target is specifying filename unless (1) path includes a trailing slash or (2) the path already exists in the workspace as a directory.
|
plugins » config-file-provider-plugin #28 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
can you add a testcase? |
|
integrated with bcd785f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for "." anywhere in full filepath is a poor way of determining whether a path is to a file or a directory. Naming conventions allow for periods in directory names and do not necessitate them in file names. As plugin currently works, /a/path.with/periods would be parsed as a file but /a/path/to/readme would be parsed as a directory.
Plugin should assume target is specifying filename unless (1) path includes a trailing slash or (2) the path already exists in the workspace as a directory.