Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for proxy authentication fill-in added #53

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sealor
Copy link

@sealor sealor commented Sep 6, 2018

When providing maven settings and global maven settings the proxy authentication is now also filled in using the Jenkins credentials if available.
The feature is similar to the authentication replacements for maven server configurations.

See https://maven.apache.org/settings.html

@sealor
Copy link
Author

sealor commented Sep 25, 2018

@imod
Do we need to create an JIRA issue before sending a pull-request?
We are longingly waiting for this proxy feature ;-)

@imod
Copy link
Member

imod commented Oct 1, 2018

@sealor its not required per se, but it helps a lot to get more context about the issue you try to solve

@jonfreedman
Copy link

It would be great to get this merged

@imod
Copy link
Member

imod commented Dec 23, 2019

@sealor I'm sure this will work, but from a users point of view, this is a hidden feature. To make this more visible (and clean), there should probably be a "Proxy Credentials" section beside the "Server Credentials" Section when editing a configuration.

this comes even more apparent when you look at the way this would look when creating a configfile with the job-dsl plugin:

configFiles {
    mavenSettingsConfig {
        id('DEFAULT_MAVEN_SETTINGS')
        name('default maven settings')
        comment('default settings for yooture projects')
        content(readFileFromWorkspace('config-files/maven-settings.xml'))
        isReplaceAll(true)
        serverCredentialMappings {
            serverCredentialMapping {
                serverId('private-release')
                credentialsId('MYUSER_MAVEN')
            }
            serverCredentialMapping {
                serverId('private-snapshot-repository')
                credentialsId('MYUSER_MAVEN_SNAPSHOT')
            }
        }        
    }
}

@sealor
Copy link
Author

sealor commented Feb 15, 2020

@imod Now, there is a "Proxy Credentials" section beside the "Server Credentials" section. The new feature behaves exactly like the other one.

@MRamonLeon MRamonLeon closed this Apr 21, 2021
@sealor
Copy link
Author

sealor commented Apr 25, 2021

@MRamonLeon
Why did you close this pull request?

I myself do not need this feature anymore because I now use another solution. But in my opinion this feature would be very helpful for others.

@MRamonLeon
Copy link
Contributor

@sealor I was scrubbing a bit and I probably misunderstood your last comment and taking into account the last time it had activity I closed it. Happy to reopen if it's still interesting. I can't commit to any review ATM though.

@MRamonLeon MRamonLeon reopened this Apr 26, 2021
@sealor
Copy link
Author

sealor commented Apr 26, 2021

@MRamonLeon
Thank you for re-opening this issue!
I did not know that there are conflicting files now. I plan to resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants