New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix casc: remove override at null getGlobalConfigPage() #56
Conversation
Hi, |
Or @jglick, @cyrille-leclerc, or @olamy. Can we get another review/merge? |
hmm, I'm confused... in #55 I was told that this is actually the important part to be implemented for jcasc... |
well yes it seems that there have been a misunderstanding on the goal of this method. From @ndeloof in gitter:
We tried locally the plugin without the override method and jcasc can configure it. Otherwise the plugin is not discoverable/seen by jcasc |
I will get this in/merged as soon as I find time to write a testcase or this PR includes one |
@tlnd-mtallet many thanks! |
released with 3.4 |
just for the record... this broke the global configuration screen and e107359 fixes it |
makes me wonder why the plugin just don't use this config.jelly for configuration |
hey guys! |
+1 I had the same question |
I'm on it - I need someone from the infra team to take a look at it |
latest version gives me an exception on Configuration page. 3.3 is fine but not 3.4.1
|
@Vincemd version 3.4 is causing this issue - 3.4.1 is released, but unfortunately not yet available in the update center - I'm already trying to contact the infra team... |
@Vincemd @davidghiurco @Enigo update center is fixed, so 3.4.1 is available now |
Fix PR #54