updated installPlugins() so we don't execute the install method if th…

…ere is no plugins to install
jenkinsci · Nov 10, 2017 · 6cae804 · 6cae804
1 parent c673d38
commit 6cae804
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/casc/ConfigurationAsCode.java b/src/main/java/org/jenkinsci/plugins/casc/ConfigurationAsCode.java
@@ -4,6 +4,7 @@
 import hudson.PluginManager;
 import hudson.init.InitMilestone;
 import hudson.init.Initializer;
+import hudson.lifecycle.RestartNotSupportedException;
 import hudson.model.Descriptor;
 import jenkins.model.Jenkins;
 import org.yaml.snakeyaml.Yaml;
@@ -134,7 +135,7 @@ private void document(String name, Set<Attribute> attributes) {
     }
 
     @Initializer(after = InitMilestone.JOB_LOADED)
-    public static void installPlugins() throws IOException {
+    public static void installPlugins() throws IOException, RestartNotSupportedException {
         // TODO get version added to the install of the plugin so we can control the specific version
         ArrayList<String> p = new ArrayList<>();
         PluginManager pluginManager = Jenkins.getInstance().pluginManager;
@@ -145,9 +146,9 @@ public static void installPlugins() throws IOException {
                 p.add(sn);
             }
         }
-
-        pluginManager.install(p, false);
-
+        if (!p.isEmpty()) {
+            pluginManager.install(p, false);
+        }
     }
 
     private static <T> T getConfigYaml(File file, Class<T> type) throws FileNotFoundException {