Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
We need to remove leading and trailing whitespace and/or newlines when reading the secrets file. They get added when using secrets with docker-compose
- Loading branch information
c83470c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like to see the reason for this change... it not obvious to me that we should trim the string here., I expect I'm allowed to use white-space for example in my passwords.
The changes was done as part of our demo project by Mads Praqma/praqma-jenkins-casc#1 and due to problems with reading the password.
We will need to look further into this issues before the above change make sense.
c83470c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be the read file to string method that gives problems.