Role Strategy Fix + Cleanup + PermissionAssert #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oleg-nenashev
commented
Feb 23, 2018
•
oleg-nenashev
commented
- Move PermissionFinder to an utility package and restrict it. I was about using this API in Role Strategy, so I have addressed the TODO comment in the code
- Fix Role Strategy integration - test is not fully correct #99
- Introduce API for checking permissions
- Add tests for Role Strategy integration - test is not fully correct #99
oleg-nenashev
changed the title
|
Tests are in progress |
oleg-nenashev
changed the title
|
@lanwen may want to criticize my old-style asserts instead of matchers, adding to Cc just in case |
lanwen
approved these changes
Feb 24, 2018
| HashSet<String> resolvedIds = new HashSet<>(); | ||
| for (String id : permissions) { | ||
| String resolvedId = PermissionFinder.findPermissionId(id); | ||
| if (resolvedId != null) { |
lanwen
approved these changes
Feb 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.