Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring max aliases for a collection #1375

Merged
merged 8 commits into from
May 24, 2020
Merged

Allow configuring max aliases for a collection #1375

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
80b822b
increase max aliases for collection
jetersen May 8, 2020
57aebdd
Move ConfigurationContext one level up to enable configurable max ali…
jetersen May 12, 2020
3b61d7e
Merge branch 'master' into fix/1374
jetersen May 24, 2020
d2a3d3f
add test for max aliases in collections
jetersen May 24, 2020
e05453a
add test for invalid input
jetersen May 24, 2020
6a5a841
provide a more helpful error message
jetersen May 24, 2020
b5bf2a8
fix imports
jetersen May 24, 2020
8455a55
check the cause message
jetersen May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion plugin/src/main/java/io/jenkins/plugins/casc/yaml/YamlUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import java.util.Iterator;
import java.util.List;
import java.util.logging.Logger;
import org.yaml.snakeyaml.LoaderOptions;
import org.yaml.snakeyaml.composer.Composer;
import org.yaml.snakeyaml.nodes.MappingNode;
import org.yaml.snakeyaml.nodes.Node;
Expand Down Expand Up @@ -49,7 +50,12 @@ public static Node merge(List<YamlSource> configs) throws ConfiguratorException
}

public static Node read(YamlSource source) throws IOException {
Composer composer = new Composer(new ParserImpl(new StreamReaderWithSource(source)), new Resolver());
LoaderOptions loaderOptions = new LoaderOptions();
loaderOptions.setMaxAliasesForCollections(100);
Composer composer = new Composer(
new ParserImpl(new StreamReaderWithSource(source)),
new Resolver(),
loaderOptions);
return composer.getSingleNode();
}

Expand Down