Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

change properties secrets env to SECRETS_FILE #1435

Merged
merged 2 commits into from Jul 19, 2020
Merged

change properties secrets env to SECRETS_FILE #1435

merged 2 commits into from Jul 19, 2020

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Jul 18, 2020

Fixes #1336

Your checklist for this pull request

馃毃 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@jetersen jetersen requested a review from a team as a code owner July 18, 2020 22:40
@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #1435 into master will decrease coverage by 0.08%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #1435      +/-   ##
============================================
- Coverage     80.66%   80.58%   -0.09%     
+ Complexity      811      810       -1     
============================================
  Files            66       66              
  Lines          2333     2333              
  Branches        329      329              
============================================
- Hits           1882     1880       -2     
  Misses          351      351              
- Partials        100      102       +2     
Impacted Files Coverage 螖 Complexity 螖
...gins/casc/impl/secrets/PropertiesSecretSource.java 81.25% <50.00%> (-6.25%) 7.00 <0.00> (酶)
.../plugins/casc/impl/secrets/DockerSecretSource.java 66.66% <0.00%> (-11.12%) 3.00% <0.00%> (-1.00%)

@jetersen jetersen added the bugfix A PR that fixes a bug - used by Release Drafter label Jul 19, 2020
@timja timja added breaking A PR that is a breaking change - used by Release Drafter chore a PR that adds to maintenance - used by Release Drafter and removed bugfix A PR that fixes a bug - used by Release Drafter labels Jul 19, 2020
@timja timja merged commit 3cddb7a into jenkinsci:master Jul 19, 2020
@jetersen jetersen deleted the fix/1336 branch July 19, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A PR that is a breaking change - used by Release Drafter chore a PR that adds to maintenance - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous use of the variable "SECRETS"
2 participants