Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use joda-time plugin for integration tests, not joda-time jar file #2436

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

MarkEWaite
Copy link
Contributor

Use joda-time plugin for integration tests, not joda-time jar file

Since the joda-time plugin is now available with the current release of the joda-time jar, let's use it in the integration tests instead of using the jar file in the integration test.

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@MarkEWaite MarkEWaite requested a review from a team as a code owner December 11, 2023 14:50
@MarkEWaite
Copy link
Contributor Author

/label test

In case I'm allowed to assign labels to pull requests

@timja timja added the test A PR that adds to testing - used by Release Drafter label Dec 11, 2023
@timja timja merged commit 21806a5 into jenkinsci:master Dec 11, 2023
16 checks passed
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it matters much, but everything else in this file is in <scope>test</scope>.

@MarkEWaite MarkEWaite deleted the use-library-plugins branch December 15, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test A PR that adds to testing - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants