Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for config-file-provider plugin (# 476) #477

Closed
wants to merge 1 commit into from

Conversation

srempfer
Copy link

#476

@ndeloof: I'm new in Jenkins plugin contribution, so please let me know what do think about the code.
Regrads Stefan

@oleg-nenashev
Copy link
Member

IMHO the fix should be done on the Config File Provider Plugin side. JCasC is in the RC state, so nothing blocks from making fixes in plugins directly

@ndeloof
Copy link
Contributor

ndeloof commented Aug 27, 2018

I agree with @oleg-nenashev that this should be proposed as an optional extension to config-file-provider, as we would like to move all custom configurators to target plugins. Also, doing so you can introduce in GlobalConfigFiles the missing setConfigs setter that make it required to implement custom code, and will just need to declare a RootConfigurator.

@srempfer
Copy link
Author

Just created a JIRA ticket (JENKINS-53247) - will try to do the compatibility changes there

@ndeloof
Copy link
Contributor

ndeloof commented Aug 27, 2018

right.
And doing so you might not even need a custom RootElementConfigurator assuming I get #480 merged

@HerrmannHinz
Copy link
Contributor

yay! super! just in time =)

@ndeloof
Copy link
Contributor

ndeloof commented Aug 29, 2018

closing this with preference to a PR on config-file-provider plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants