🚧 target Jenkins v164.1 #790
Conversation
plugin/src/main/java/io/jenkins/plugins/casc/core/AdminWhitelistRuleConfigurator.java
Outdated
Show resolved
Hide resolved
|
I honestly have given up on Jenkins CI, Travis at the moment does precisely the same as what Jenkins CI does and faster 😢 Except for Windows but appveyor shouldn't be too hard to add. |
|
SpotBugs failure on Jenkins CI is due to spotbugs/spotbugs#756 |
jetersen
force-pushed
the
JenkinsV164.1
branch
2 times, most recently
from
70e7b91
to
ce27dc2
Compare
|
👍 for 🚀 |
.travis.yml
Outdated
| @@ -0,0 +1,18 @@ | |||
| language: java | |||
There was a problem hiding this comment.
Well, it is kind of related. I was blocked by Jenkins CI trying to use JDK 11, and I needed to know if we could build with JDK 11!
|
I just did a lot of work on: jenkinsci/github-plugin#209 would that then cause an issue to to get jenkinsci/github-plugin#210 working? |
|
There should be no internal changes that should make your work obsolete. You can still use an older version for the plugin testing. I think one of the main reason I want to bump is to avoid maintaining a lot of legacy/version matching dance to add some functionality like #788 Perhaps that is a lousy argument but an argument none the less.
https://stats.jenkins.io/pluginversions/configuration-as-code.html |
|
Nice it does exist 🎉 |
|
Reading those numbers, it might make sense to do the version dance. 😢 1 Jenkins server with version |
|
Might be best to wait for next months numbers run and see how 2.164.1 is looking |
|
We can just pin the PR for later and do the version dance in #788 |
ewelinawilkosz
added
the
pinned
We can. It was a part of our smoke tests since October |
There was a problem hiding this comment.
I am not sure it is a good idea. If we ever need to extend the configurator API to offer more compatibility tools for plugins, it will require these plugins to be updated to the recent LTS. And it may be a non-starter for some plugin maintainers.
Unfortunately #279 was rejected, otherwise we could have maintained the majority of the codebase on the latest LTS.
Please do not merge right now, let's discuss it at the project meeting
|
it was already marked a WIP 😰 so no worries @oleg-nenashev |
|
Yeah, just wanted to make sure we discuss it before merge
…On Sat, May 25, 2019, 13:42 Joseph Petersen ***@***.***> wrote:
it was already marked a WIP 😰 so no worries @oleg-nenashev
<https://github.com/oleg-nenashev>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#790?email_source=notifications&email_token=AAW4RIDVEBGCY56CSJQVALDPXEQ3ZA5CNFSM4HAUILQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWHQDKA#issuecomment-495911336>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW4RICEZD6DG5MDQPYRGXTPXEQ3ZANCNFSM4HAUILQQ>
.
|
|
Closing as we will most likely split into configurator API |
Here is our checklist for contributors. No hard requirement here, just a reminder
Let's discuss targeting the v2.164.1 LTS, the project is pretty stable.
There are a few PRs we could get in and release before bumping.
The bump would be welcomed this is, after all, JCasC we should be able to safely bump core version without too much fuss from Jenkins users.
Would be great to know we can run on Java 11 runtime!
Link to issue you're working on if there's a relevant one
Did you provide a test-case to demonstrate feature actually works / issue is fixed ?
Please also consider adding a line to CHANGELOG.md
Changelog will be added later.