Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use jenkins infra maven cd reusable workflow #117

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

jetersen
Copy link
Member

馃 Beep boop!

This is an automatic pull request that updates your GitHub action used for continous delivery workflow for this repository.

Switching to using a reusable workflow created to simplify maintance of this file in your repository.

In case of questions, please ping @jetersen.

Additional informations:
You can find the workflow here

@guysoft
Copy link
Contributor

guysoft commented Jun 15, 2022

Hey, just to confirm that there was a ci change that requires this?
@jetersen

@jetersen
Copy link
Member Author

jetersen commented Jun 15, 2022

No change to the CI makes this change required, basically the two workflow function exactly the same.
Although using the reusable workflow allows you to get updates to workflow every time we update the v1 tag on the reusable workflow repository.
Feel free to close the PR.

This is meant to simplify the workflow for you and reduce the amount you need to maintain it.

You can find more details in these PR:
jenkins-infra/github-reusable-workflows#1
jenkinsci/.github#86

This PR updates your file to look like: https://github.com/jenkinsci/.github/blob/d65bdd80b695ba8185478205e49c0172f8629bb2/workflow-templates/cd.yaml

This will allow you to get rid of dependabot noise for this GitHub actions

image

@jetersen
Copy link
Member Author

jetersen commented Jun 15, 2022

One change that did happen is an improvement to the workflow.

This release of https://github.com/jenkins-infra/interesting-category-action/releases/tag/v1.2.0 allows us to pass the release draft body directly between the output of the release drafter action, see: https://github.com/jenkins-infra/github-reusable-workflows/pull/3/files

@guysoft guysoft merged commit 6b33b6e into jenkinsci:master Jun 15, 2022
@jetersen jetersen deleted the chore/maven-cd-reusable-workflow branch June 15, 2022 10:30
This was referenced Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants