Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and standardize pom #193

Merged
merged 6 commits into from
Mar 17, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Mar 16, 2023

Simplify and standardize the pom file

Reduce the plugin dependencies so that there are fewer dependencies to manage.

Move the spotbugs exclusions file to the standard location so that default settings are used.

Use library plugins instead of bundling jar files in the plugin so that version management is delegated to the plugin BOM.

Would have used the jsoup plugin instead of the jsoup library, but the jsoup plugin is badly outdated.

  • Use most recent plugin bom
  • Use parent pom 4.56
  • Use spotbugs default settings
  • Remove unused plexus dependency
  • Use httpclient plugin instead of library
  • Use commons lang3 plugin instead of library
  • Remove spotbugs annotations dependency

All the changes should be behavior preserving with no change to functionality.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite requested review from NotMyFault and gounthar and removed request for NotMyFault March 17, 2023 00:08
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So so much cleaner, thanks a lot, Mark. 🤗

@gounthar gounthar merged commit a85da25 into jenkinsci:master Mar 17, 2023
@MarkEWaite MarkEWaite deleted the simplify-dependencies branch March 17, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants