Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect confluence RPC service URL creation #1

Merged
merged 1 commit into from Apr 25, 2011

Conversation

Projects
None yet
2 participants
@jcsirot
Copy link
Member

commented Apr 23, 2011

When confluence is not installed on the "/" path of the server (e.g. http://example.com/confluence/) the path element of the base URL is truncated (e.g. http://example.com/rpc/soap-axis/confluenceservice-v1) and the RPC service URL is incorrect leading to HTTP 404 error.

@jhansche

This comment has been minimized.

Copy link

commented on dd0ecf4 Apr 25, 2011

Hmm, yeah the reason I used .resolve() was in case someone copied, for example, a Confluence page URL. But I didn't think of the case where Confluence is not installed at the root.

In this case, though, I guess the login test would catch that, so it's less of a problem.

@jhansche jhansche merged commit dd0ecf4 into jenkinsci:master Apr 25, 2011

jhansche added a commit that referenced this pull request Jun 19, 2011

Fix bug with GH-1 for root-installations.
The change made in dd0ecf4 fixed the URLs for Confluence
installations in non-root paths (e.g., http://foo.example.com/confluence/*),
but that broke root installations, because URI#resolve()
interprets "//foo/bar" to mean that the host should become "foo".

Instead of using getPath(), and appending a /-anchored
RPC path, just pass a relative path to URI#resolve().
This should solve both problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.