Incorrect confluence RPC service URL creation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhansche
pushed a commit
that referenced
this pull request
Jun 19, 2011
The change made in dd0ecf4 fixed the URLs for Confluence installations in non-root paths (e.g., http://foo.example.com/confluence/*), but that broke root installations, because URI#resolve() interprets "//foo/bar" to mean that the host should become "foo". Instead of using getPath(), and appending a /-anchored RPC path, just pass a relative path to URI#resolve(). This should solve both problems.
jhansche
pushed a commit
that referenced
this pull request
Jan 13, 2020
Due to https://issues.jenkins-ci.org/browse/JENKINS-47309 and as stated at https://developer.atlassian.com/server/confluence/confluence-xml-rpc-and-soap-apis/ "The XML-RPC and SOAP APIs are deprecated since Confluence 5.5, and may not work as expected." this PR is intended to introduce an upgrade of confluence-publisher-plugin with com.atlassian.confluence:confluence-rest-client:6.15.7 * cleanup + upgrade with confluence-rest-client * upgrade with confluence-rest-client + some cleanup * rewrite performEditComment/createComment * add ancestors inheritance. * add type to createPage * editComment + previousComment lookup * corrected parent set, saves pages hierarchy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When confluence is not installed on the "/" path of the server (e.g. http://example.com/confluence/) the path element of the base URL is truncated (e.g. http://example.com/rpc/soap-axis/confluenceservice-v1) and the RPC service URL is incorrect leading to HTTP 404 error.