Skip to content

Commit

Permalink
Explain maven plugin version pin in a comment
Browse files Browse the repository at this point in the history
jenkinsci/bom#1978 notes that the upgrade of
the optional dependency on the maven plugin from 3.16 to 3.21 caused
the Jenkins plugin bill of materials to need an explicit inclusion of
the Jenkins maven plugin into the plugin BOM.

That's not a desired change because the Jenkins maven plugin tests do
not pass when run in the Jenkins plugin BOM test suites.  We don't
want to invest the effort in the Jenkins maven plugin tests to make
them work in the Jenkins plugin BOM.

The #174
dependabot proposed upgrade is being reverted to avoid the problem.
When dependabot next proposes an upgrade of this dependency, it can be
closed or evaluated as an incremental build in the Jenkins plugin BOM
before the upgrade is approved.
  • Loading branch information
MarkEWaite committed Apr 20, 2023
1 parent 8f6f149 commit ad483d5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@
<dependency>
<groupId>org.jenkins-ci.main</groupId>
<artifactId>maven-plugin</artifactId>
<!-- Intentionally kept at 3.16 to not disrupt Jenkins plugin bill of materials -->
<!-- https://github.com/jenkinsci/bom/pull/1978#issuecomment-1516220549 -->
<!-- TODO: Before upgrading this version, must check that plugin bill of materials is unharmed -->
<version>3.16</version>
<optional>true</optional>
</dependency>
Expand Down

0 comments on commit ad483d5

Please sign in to comment.