Fix tests failing for accessing http://repo1.maven.org/ #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikedam
commented
Feb 29, 2020
Comment on lines
+16
to
+27
| <repositories> | ||
| <repository> | ||
| <id>central</id> | ||
| <url>https://repo.maven.apache.org/maven2</url> | ||
| </repository> | ||
| </repositories> | ||
| <pluginRepositories> | ||
| <pluginRepository> | ||
| <id>central</id> | ||
| <url>https://repo.maven.apache.org/maven2</url> | ||
| </pluginRepository> | ||
| </pluginRepositories> |
There was a problem hiding this comment.
I added this to all pom files.
Adding this only to the root pom doesn't resolve the problem. It might caused for submodules doesn't inherit the parent module explicitly. (I don't know about detailed behavior of maven)
Adding this only to moduleA might resolve the problem as the artifacts will be downloaded for moduleA, and cached and reused for moduleB, moduleC. But that's just a workaround and not a good solution.
ikedam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-61276
It's caused for pom files in zip.
It's difficult to review, then