Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test dep on compress-artifacts #163

Merged
merged 1 commit into from Jan 22, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 18, 2023

Problematic for various reasons (not in BOM, uses an obsolete library, pulls in BouncyCastle not through the plugin). Easiest to just remove this test dep as it should add no interesting test coverage beyond what we already get from the workflow-api:tests dep. See jenkinsci/bom#1689 (comment) for context.

@jglick jglick requested a review from a team as a code owner January 18, 2023 12:31
@MarkEWaite
Copy link
Contributor

@ikedam or @wolfs are you available to merge this pull request and release a new version?

@jglick
Copy link
Member Author

jglick commented Jan 20, 2023

FWIW I have write access in GitHub for some reason, but am not in the maintainers list in RPU and do not particularly want to adopt. It appears @basil has recently performed a release, but @ikedam has also recently committed.

@basil
Copy link
Member

basil commented Jan 20, 2023

@jglick jenkins-infra/repository-permissions-updater#2997 Do not ping me regarding this plugin

@MarkEWaite MarkEWaite merged commit ebd6baf into jenkinsci:master Jan 22, 2023
@MarkEWaite MarkEWaite added test and removed developer labels Jan 22, 2023
@basil
Copy link
Member

basil commented Jan 22, 2023

BTW @jglick I asked you a question in jenkinsci/pom#371 (comment) and you have not responded.

@MarkEWaite MarkEWaite changed the title Removing test dep on compress-artifacts Remove test dep on compress-artifacts Jan 23, 2023
@jglick jglick deleted the compress-artifacts branch January 23, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants