Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty translation properties #171

Merged
merged 1 commit into from Jan 30, 2023

Conversation

MarkEWaite
Copy link
Contributor

Remove empty translation properties

#169 added empty translation strings. They will cause the two items to be shown as empty strings in the local language versions (German and Japanese). Better to remove the empty translation properties so that the English will be displayed.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

#169 added empty
translation strings.  They will cause the two items to be shown as
empty strings in the local language versions (German and Japanese).
Better to remove the empty translation properties so that the English
will be displayed.
Copy link
Contributor

@allancth allancth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarkEWaite for the PR.

@MarkEWaite
Copy link
Contributor Author

Thanks @MarkEWaite for the PR.

You're welcome. If you click the "Enable auto-merge" then it will; merge when CI passes.

@MarkEWaite
Copy link
Contributor Author

MarkEWaite commented Jan 30, 2023

@allancth you will have received an email invitation to join the jenkinsci organization on GitHub. You'll need to accept that invitation before you'll be a member of the group that maintains the plugin.

See jenkins-infra/repository-permissions-updater#3108 (comment) for the details

@allancth allancth merged commit 6fd3701 into master Jan 30, 2023
@allancth allancth deleted the remove-empty-translation-strings branch January 30, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants