Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade HtmlUnit from 2.x to 3.x #193

Merged
merged 1 commit into from
Jun 4, 2023
Merged

Upgrade HtmlUnit from 2.x to 3.x #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.65</version>
<version>4.66</version>
<relativePath />
</parent>

Expand Down
12 changes: 6 additions & 6 deletions src/test/java/hudson/plugins/copyartifact/BuildSelectorParameterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@
*/
package hudson.plugins.copyartifact;

import com.gargoylesoftware.htmlunit.HttpMethod;
import com.gargoylesoftware.htmlunit.WebClientOptions;
import com.gargoylesoftware.htmlunit.WebRequest;
import com.gargoylesoftware.htmlunit.html.HtmlForm;
import com.gargoylesoftware.htmlunit.util.NameValuePair;
import org.htmlunit.HttpMethod;
import org.htmlunit.WebClientOptions;
import org.htmlunit.WebRequest;
import org.htmlunit.html.HtmlForm;
import org.htmlunit.util.NameValuePair;
import hudson.cli.CLICommandInvoker;
import hudson.model.FreeStyleProject;
import hudson.model.ParametersDefinitionProperty;
Expand Down Expand Up @@ -72,7 +72,7 @@ public void testParameter() throws Exception {
HtmlForm form = wc.getPage(job, "build").getFormByName("parameters");
form.getSelectByName("").getOptionByText("Specific build").setSelected(true);
wc.waitForBackgroundJavaScript(10000);
form.getInputByName("_.buildNumber").setValueAttribute("6");
form.getInputByName("_.buildNumber").setValue("6");
rule.submit(form);
rule.waitUntilNoActivity();
assertEquals("<SpecificBuildSelector><buildNumber>6</buildNumber></SpecificBuildSelector>",
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/hudson/plugins/copyartifact/CopyArtifactConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
import org.jvnet.hudson.test.JenkinsRule;
import org.jvnet.hudson.test.TestExtension;

import com.gargoylesoftware.htmlunit.html.HtmlForm;
import org.htmlunit.html.HtmlForm;

import hudson.XmlFile;
import hudson.model.Saveable;
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@
import org.jvnet.hudson.test.recipes.WithPlugin;

import com.cloudbees.hudson.plugins.folder.Folder;
import com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException;
import com.gargoylesoftware.htmlunit.HttpMethod;
import com.gargoylesoftware.htmlunit.WebRequest;
import org.htmlunit.FailingHttpStatusCodeException;
import org.htmlunit.HttpMethod;
import org.htmlunit.WebRequest;

import static org.hamcrest.Matchers.not;
import static org.junit.Assert.assertEquals;
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/hudson/plugins/copyartifact/testutils/CopyArtifactJenkinsRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
import org.jvnet.hudson.test.ExtractResourceSCM;
import org.jvnet.hudson.test.JenkinsRule;

import com.gargoylesoftware.htmlunit.WebResponse;
import org.htmlunit.WebResponse;

import hudson.scm.SCM;

Expand Down